Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: disabledDate Template Broken #13695

Closed
Ryan-h1 opened this issue Sep 18, 2023 · 0 comments · Fixed by #13733
Closed

Calendar: disabledDate Template Broken #13695

Ryan-h1 opened this issue Sep 18, 2023 · 0 comments · Fixed by #13733
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.4.0

Comments

@Ryan-h1
Copy link

Ryan-h1 commented Sep 18, 2023

Describe the bug

Overriding the disabledDate template does not work — other templates, such as header and date, work, but not this particular one.

Environment

Compilation tested on Mac OS, Windows, and Stackblitz. All modern browsers tested.

Reproducer

No response

Angular version

16.2.5

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.10.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://stackblitz.com/github/Ryan-h1/primeng-calendar-issue-demo?file=src%2Fapp%2Fapp.component.ts
  2. Open the calendar
  3. Observe that the strikethrough style does not display on disabled dates, yet if you change the 'disabledDate' template to 'date', the strikethrough applies to all dates.

Expected behavior

I expected that by overriding the disabledDate template it would apply my custom style to disabledDates.
@Ryan-h1 Ryan-h1 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 18, 2023
@Ryan-h1 Ryan-h1 changed the title Component: Title Calendar: disabledDate Template Broken Sep 18, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 25, 2023
@ashikjs
fix: primefaces#13695 || Calendar: disabledDate Template Broken
fa3cca6
@ashikjs ashikjs mentioned this issue Sep 25, 2023
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 25, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.0 milestone Sep 25, 2023
cetincakiroglu added a commit that referenced this issue Sep 25, 2023
@cetincakiroglu
Merge pull request #13733 from ashikjs/issues/13695/calender-siabled-…
ae1c5d7 
…date-template-not-working

fix: #13695 || Calendar: disabledDate Template Broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.4.0
Development

Successfully merging a pull request may close this issue.

fix: #13695 || Calendar: disabledDate Template Broken ashikjs/primeng
2 participants
@Ryan-h1 @cetincakiroglu