Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pKeyFilter stops Enter key from submitting form in Firefox #13246

Closed
driftfox opened this issue Jun 23, 2023 · 2 comments
Closed

pKeyFilter stops Enter key from submitting form in Firefox #13246

driftfox opened this issue Jun 23, 2023 · 2 comments
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.3.0

Comments

@driftfox
Copy link
Contributor

driftfox commented Jun 23, 2023 •
edited
Loading

Describe the bug

If an input in a form has pKeyFilter="pint" on it, you can't submit the form just by pressing the Enter key.

This issue is identical to #5931 but applies specifically to Firefox. It is not an issue in in Chrome 114.0.5735.134.

Environment

An Angular application with forms

Reproducer

https://stackblitz.com/edit/js7ac5?file=src%2Fapp%2Fdemo%2Fkey-filter-presets-demo.ts

Angular version

15.2.1, 16.0.0

PrimeNG version

15.2.0, 16.0.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.12.1

Browser(s)

Firefox 114.0.1 (64-bit)

Steps to reproduce the behavior

  1. Add a <form> element with a method bound to (ngSubmit).
  2. Add an <input> element with pKeyFilter="pint" inside the <form>.
  3. View this page in Firefox.
  4. Enter a value in the and press Enter on the keyboard.
  5. Notice that the method bound to (ngSubmit) is not called.

Expected behavior

Pressing Enter should call the method bound to (ngSubmit).
@driftfox driftfox added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 23, 2023
driftfox added a commit to driftfox/primeng that referenced this issue Jun 23, 2023
@driftfox
Fixed primefaces#13246 - Do not prevent Enter key when using pKeyFilter
c19701d
driftfox added a commit to driftfox/primeng that referenced this issue Jun 23, 2023
@driftfox
Fix primefaces#13246 - Do not prevent Enter key when using pKeyFilter
bad9d59
@driftfox driftfox mentioned this issue Jun 23, 2023
Merged
@driftfox
Copy link
Contributor Author

For reference, the fix I'm introducing in this PR was originally added with c488091 and then later removed in eb3f8a4.

@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 26, 2023
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 26, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 26, 2023
@mertsincan
Copy link
Member

Fixed in #13247

@gucal gucal added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.3.0
Development

No branches or pull requests
4 participants
@driftfox @mertsincan @gucal @cetincakiroglu