Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password input with reactive form, does not disable until clicked even though control is reported as disabled. #12317

Closed
evanwellens opened this issue Dec 1, 2022 · 0 comments · Fixed by #12345
Closed

Password input with reactive form, does not disable until clicked even though control is reported as disabled. #12317

evanwellens opened this issue Dec 1, 2022 · 0 comments · Fixed by #12345
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
15.0.1

Comments

@evanwellens
Copy link

Describe the bug

Password input with reactive form, does not disable until clicked even though control is reported as disabled. Similar to issue 10788. Call disable on the form control , and it will let you type, until focus is lost then it becomes readonly.

Environment

angular 13.2.6
primeng 13.4.1

Reproducer

No response

Angular version

13.2.6

PrimeNG version

13.4.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

14.16.1

Browser(s)

Chrome

Steps to reproduce the behavior

Call disable on the form control , and it will let you type, until focus is lost then it becomes readonly.

Expected behavior

The control should be read only when disable() is called.
@evanwellens evanwellens added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 1, 2022
volvachev added a commit to volvachev/primeng that referenced this issue Dec 6, 2022
@volvachev
fix(primeng/p-password): update disable logic for reactive controls
d33ce6d 
Fixes primefaces#12317.
@volvachev volvachev mentioned this issue Dec 6, 2022
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 20, 2022
@cetincakiroglu cetincakiroglu added this to the 15.0.1 milestone Dec 20, 2022
@cetincakiroglu cetincakiroglu self-assigned this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
15.0.1
Development

Successfully merging a pull request may close this issue.

fix(primeng/p-password): update disable logic for reactive controls volvachev/primeng
2 participants
@evanwellens @cetincakiroglu