Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primeicons.ts not updated for v6 missing strings. #12105

Closed
albert-m-willemsen opened this issue Oct 28, 2022 · 0 comments · Fixed by #12106
Closed

primeicons.ts not updated for v6 missing strings. #12105

albert-m-willemsen opened this issue Oct 28, 2022 · 0 comments · Fixed by #12106
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
14.2.0

Comments

@albert-m-willemsen
Copy link

Describe the bug

The primeicons.d.ts for v6 is missing some icon strings.
236 icon strings found. While the pack contains ~260 icons.

Environment

Latest stable PrimeNG + PrimeIcons 6.

Reproducer

No response

Angular version

14.2.1

PrimeNG version

14.1.2

Build / Runtime

Angular CLI App

Language

ALL

Node version (for AoT issues node --version)

v16.17.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@albert-m-willemsen albert-m-willemsen added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 28, 2022
@albert-m-willemsen albert-m-willemsen mentioned this issue Oct 28, 2022
Open
@cetincakiroglu cetincakiroglu added this to the 14.2.0 milestone Oct 28, 2022
@cetincakiroglu cetincakiroglu self-assigned this Oct 28, 2022
@cetincakiroglu cetincakiroglu changed the title primeicons.d.ts not updated for v6 missing strings. primeicons.ts not updated for v6 missing strings. Oct 28, 2022
cetincakiroglu added a commit that referenced this issue Oct 28, 2022
@cetincakiroglu
Fixed #12105 - primeicons.ts not updated for v6 missing strings.
9d95904
@cetincakiroglu cetincakiroglu linked a pull request Oct 28, 2022 that will close this issue
Fixed #12105 - primeicons.ts not updated for v6 missing strings. #12106
Merged
cetincakiroglu added a commit that referenced this issue Oct 28, 2022
@cetincakiroglu
Merge pull request #12106 from primefaces/issue-12105
cc02231 
Fixed #12105 - primeicons.ts not updated for v6 missing strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
14.2.0
Development

Successfully merging a pull request may close this issue.

Fixed #12105 - primeicons.ts not updated for v6 missing strings. primefaces/primeng
2 participants
@albert-m-willemsen @cetincakiroglu