Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuBar: Menu Icon in mobile view is shown even though there are no items in model #12084

Closed
tfohlmeister opened this issue Oct 22, 2022 · 0 comments · Fixed by #12123
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@tfohlmeister
Copy link

Describe the bug

While the menu bar handles empty or NULL values for [model] gracefully in normal situations, once switched to the mobile view (max-width <= 960px) a menu-icon is shown no matter what.

It is confusing to a user if the menu bar shows this menu-icon and even displays a menu stub on click but no content is rendered.

Environment

Default / standard

Reproducer

https://stackblitz.com/edit/github-lcf9ws

Angular version

14.2.1

PrimeNG version

14.1.2

Build / Runtime

Angular CLI App

Language

ALL

Node version (for AoT issues node --version)

16.16.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Use my example from https://stackblitz.com/edit/github-lcf9ws
  2. Click menu icon (burger menu)
  3. You see a menu sub popping up below the icon

Expected behavior

When the model input on menubar is falsely or an empty array, the menu icon should never be visible.

@tfohlmeister tfohlmeister added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 22, 2022
@cetincakiroglu cetincakiroglu added this to the 14.2.0 milestone Nov 2, 2022
gucal added a commit that referenced this issue Nov 2, 2022
@gucal gucal removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 2, 2022
@gucal gucal linked a pull request Nov 2, 2022 that will close this issue
cetincakiroglu added a commit that referenced this issue Nov 8, 2022
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
3 participants