Skip to content

Commit

Permalink
fixed #7904 p-dropdown not closing when clicking outside of the contr…
Browse files Browse the repository at this point in the history
…ol itself
  • Loading branch information
yigitfindikli committed Jul 9, 2019
1 parent 4be5857 commit 2944fce
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/app/components/dropdown/dropdown.ts
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,8 @@ export class Dropdown implements OnInit,AfterViewInit,AfterContentInit,AfterView
this.hide();
else
this.show();

this.cd.detectChanges();
}
}

Expand Down Expand Up @@ -561,7 +563,6 @@ export class Dropdown implements OnInit,AfterViewInit,AfterContentInit,AfterView
break;

case 'void':
this.onHide.emit(event);
this.onOverlayHide();
break;
}
Expand Down Expand Up @@ -614,6 +615,7 @@ export class Dropdown implements OnInit,AfterViewInit,AfterContentInit,AfterView
}

this.cd.markForCheck();
this.onHide.emit(event);

This comment has been minimized.

Copy link
@thaihacong

thaihacong Jul 30, 2019

This causes #8003.

}

alignOverlay() {
Expand Down

0 comments on commit 2944fce

Please sign in to comment.