Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin h5py and require fixed h5netcdf version. #22

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

mikapfl
Copy link
Member

@mikapfl mikapfl commented Mar 1, 2021

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Description in CHANGELOG.rst added

Description

h5py was pinned due to API changes in Version 3, but this was fixed in xarray at pydata/xarray#4893 , so we can now unpin h5py but have to use a newer h5netcdf.

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #22 (6361a4f) into main (5308bad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          21       21           
  Lines        1292     1292           
=======================================
  Hits         1285     1285           
  Misses          7        7           
Impacted Files Coverage Δ
primap2/_data_format.py 98.80% <ø> (ø)
primap2/_setters.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06ff505...26a3ea7. Read the comment docs.

@mikapfl mikapfl merged commit 3f1f442 into primap-community:main Mar 1, 2021
@mikapfl mikapfl deleted the h5py-3 branch March 1, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant