[PLATFORM-1399]: Update otel deps #83
Conversation
| tracing = {version = "0.1", features = ["max_level_debug", "release_max_level_info"]} | ||
| tracing-log = {version = "0.2"} | ||
| tracing-opentelemetry = {version = "0.21", optional = true} | ||
| tracing-opentelemetry = {version = "0.22", optional = true} |
There was a problem hiding this comment.
Slightly worried about this being 0.22, while the other otel libraries are 0.21, are you sure these are compatible?
There was a problem hiding this comment.
Tracing-opentelemetry 0.22 has "opentelemetry 0.21.0" in its deps (that is a bit nonsense)
There was a problem hiding this comment.
One attention point could be prima_bridge and tracing-actix-web that both still have tracing-opentelemetry 0.21.0 (that carries opentelemetry 0.20.0)
Edit: but they are in the dev-dependencies.. So not an issue i guess
There was a problem hiding this comment.
I didn't notice this, thanks! tracing-actix-web we can easily be bumped, prima_bridge (bridge.rs?) cannot and I don't like having incompatible deps but it's used in an example...
There was a problem hiding this comment.
Yes. I guess it's fine this way and we can think about updating bridge.rs otel deps later on
cpiemontese
dismissed stale reviews from MaeIsBad and cottinisimone
via
2f341f0
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-1399
In this PR
opentelemetryhas been bumped to0.21and thert-tokiofeature has been removedopentelemetry-otlphas been bumped to0.14opentelemetry_sdkhas been introduced, with thert-tokiofeaturetracing-opentelemetryis now0.22to match the other otel depsrt-tokio-current-threadto map to["opentelemetry_sdk/rt-tokio-current-thread"], since the tokio stuff has been moved toopentelemetry_sdk