Add feature for starting opentelemetry with tokio current thread runtime #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miterst
requested review from
wolf4ood and
matteosister
and removed request for
wolf4ood
matteosister
approved these changes
Mar 11, 2022
Comment on lines
+20
to
+29
| let runtime = { | ||
| #[cfg(feature = "rt-tokio-current-thread")] | ||
| { | ||
| opentelemetry::runtime::TokioCurrentThread | ||
| } | ||
| #[cfg(not(feature = "rt-tokio-current-thread"))] | ||
| { | ||
| opentelemetry::runtime::Tokio | ||
| } | ||
| }; |
There was a problem hiding this comment.
never saw scopes used like this!
wolf4ood
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
rt-tokio-current-threadfeature that activates the same feature on opentelemetry.Using this feature resolves the problem of graceful app shutdown when using the actix runtime #24.