Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVEX-2390]: Allow for higher log levels in release mode #128

Merged
merged 3 commits into from
Dec 3, 2024
Merged

[DEVEX-2390]: Allow for higher log levels in release mode #128

merged 3 commits into from
Dec 3, 2024

Conversation

MaeIsBad
Copy link
Member

@MaeIsBad MaeIsBad commented Dec 3, 2024

@MaeIsBad MaeIsBad requested a review from a team as a code owner December 3, 2024 14:21
cpiemontese
cpiemontese approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@cpiemontese cpiemontese left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda fear spam from debug logs to crop up without people knowing, especially given that this is just a patch... should we make it a minor...? 🤔

@MaeIsBad
Copy link
Member Author

MaeIsBad commented Dec 3, 2024

As I wrote in the changelog, we set a default in the env filter anyways. I think it's fine as is

@MaeIsBad MaeIsBad merged commit 94b33d8 into master Dec 3, 2024
7 checks passed
@MaeIsBad MaeIsBad deleted the DEVEX-2390/task/allow-for-higher-log-levels-in-release-mode branch December 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpiemontese cpiemontese cpiemontese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaeIsBad @cpiemontese