[PLATFORM-573]: [esrs] POC different projectors on same table #99
Conversation
| // This is where some cleanup action would go in a more complex system | ||
| } | ||
| } | ||
| state + 1 |
There was a problem hiding this comment.
Why not let the state be the counter of every successful logged messages? So that the state at this time could be changed here in the matches
There was a problem hiding this comment.
I'm using the state here to illustrate the number of events persisted for a given command, so the person reading the example can easily see "ok so when I log a message an event is created to do the logging and then another is created due to the saga policy" etc. I don't mind moving it in to the match, but the idea was just to use it to illustrate the multiple events per command (obviously for the example the aggregate state isn't really necessary)
There was a problem hiding this comment.
I'm also using it to illustrate how the state returned from handle_command is made invalid by the policy (see comments in main.rs), so always needs to be rebuilt from the DB - moving to inside the match arm for logging wouldn't allow me to do that easily
There was a problem hiding this comment.
Ok, but why don't give to the state more sense using it in the match..?
There was a problem hiding this comment.
It's easier to illustrate to potential users about the invalid state if it's a simple count of persisted events, that's why.
There was a problem hiding this comment.
I am not following the discussion 😆 what's the problem?
There was a problem hiding this comment.
I think Simone is asking why I'm using the AggregateState to track the number of events processed, rather than the number of lines logged, and I'm explaining that I'm using it to track the number of events persisted rather than the number of lines logged because it lets me demonstrate a couple of quirks of implementing a saga like this (using a Policy to send the Aggegate another command during the handling of the first one) slightly more straightforwardly.
It's not really a hugely meaningful difference, but I think this way allows me to be clearer in the comments describing what's going on. I'm not sure if/why a difference of opinion this minor is blocking
Resolved and added, thank you! |
oliverbrowneprima
deleted the
PLATFORM-573/user-story/esrs-poc-different-projectors-on-same-table-1
branch
[PLATFORM-573]: First step - removed old examples, added the simpler new ones