Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLATFORM-514]: [Esrs] Update sqlx & uuid #91

Merged
merged 5 commits into from
Jun 20, 2022
Merged

[PLATFORM-514]: [Esrs] Update sqlx & uuid #91

merged 5 commits into from
Jun 20, 2022

Conversation

cpiemontese
Copy link
Contributor

@cpiemontese cpiemontese requested review from fabuloso and Fs00 June 17, 2022 08:16
fabuloso
fabuloso previously approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@fabuloso fabuloso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top

Fs00
Fs00 reviewed Jun 17, 2022
View reviewed changes
Copy link
Contributor

@Fs00 Fs00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we support both uuid 0.8 and 1.x with a version range constraint like ">=0.8.0, <2.0.0"?
It seems we only use the Uuid::new_v4 function

nvm, given that sqlx supports only uuid 1.x it makes sense to raise the requirement

@cpiemontese cpiemontese requested review from Fs00 and fabuloso June 17, 2022 09:12
@cpiemontese
Copy link
Contributor Author

We had to bump the min version of Rust to 1.58 do to problems with resolving sqlx-core. Is this fine?

@cpiemontese cpiemontese requested review from cottinisimone and removed request for cottinisimone June 20, 2022 08:07
cottinisimone
cottinisimone reviewed Jun 20, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
cottinisimone
cottinisimone previously approved these changes Jun 20, 2022
View reviewed changes
@cpiemontese @cottinisimone
Update Cargo.toml
0f544a8 
Co-authored-by: Simone Cottini <[email protected]>
Fs00
Fs00 previously approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@Fs00 Fs00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add this to the Cargo.toml:

rust-version = "1.58.0"

See https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field

@cpiemontese cpiemontese requested a review from Fs00 June 20, 2022 08:18
@cottinisimone cottinisimone merged commit 3618438 into master Jun 20, 2022
@cottinisimone cottinisimone deleted the PLATFORM-514/user-story/update-deps branch June 20, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabuloso fabuloso fabuloso approved these changes

@Fs00 Fs00 Fs00 approved these changes

@matteosister matteosister Awaiting requested review from matteosister

@cottinisimone cottinisimone Awaiting requested review from cottinisimone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpiemontese @fabuloso @cottinisimone @Fs00