make the AggregateManager deref blanket implementation work for smart pointers #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelo-rendina-prima
force-pushed
the
fix-blanket-implementation-for-aggregate-manager
branch
from
78116fd to
9e78b5d
Compare
cottinisimone
previously approved these changes
Feb 5, 2024
cottinisimone
changed the base branch from
master
to
PLATFORM-1504/bug/examples-are-not-compiling-with-rust-1-75
cottinisimone
force-pushed
the
fix-blanket-implementation-for-aggregate-manager
branch
from
9e78b5d to
191b8b7
Compare
Base automatically changed from
PLATFORM-1504/bug/examples-are-not-compiling-with-rust-1-75
to
master
February 9, 2024 09:55
cottinisimone
approved these changes
Feb 9, 2024
angelo-rendina-prima
deleted the
fix-blanket-implementation-for-aggregate-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blanket implementation should be generic in the EventStore.
As it is currently written, it works for (smart) pointers to trait objects ONLY, and not for concrete types that implement the EventStore trait, e.g.
Arc<dyn EventStore>receives the target implementation, whereasArc<PgStore>does not