[PLATFORM-1085]: Add some event bus specific impl #155
Conversation
| use crate::Aggregate; | ||
|
|
||
| #[derive(TypedBuilder)] | ||
| pub struct RabbitEventBusConfig<'a> { |
There was a problem hiding this comment.
Honestly not so sure about if this builder patter with typed-builder makes sense or is better to implement a manual builder..
There was a problem hiding this comment.
Since this builder has 9000 fields I don't see why not use typed-builder?
| use crate::Aggregate; | ||
|
|
||
| #[derive(TypedBuilder)] | ||
| pub struct RabbitEventBusConfig<'a> { |
There was a problem hiding this comment.
Since this builder has 9000 fields I don't see why not use typed-builder?
cottinisimone
dismissed stale reviews from cpiemontese and oliverbrowneprima
via
0672524
| topic: String, | ||
| request_timeout: Duration, | ||
| error_handler: Box<dyn Fn(KafkaEventBusError) + Send + Sync>, | ||
| _phantom: PhantomData<A>, |
There was a problem hiding this comment.
Is the phantom data really needed?
There was a problem hiding this comment.
Yes, because KafkaEventBus takes that A generic that is not used in any field of the struct otherwise..
|
@ollaw can you please sign the drone.yml file? |
|
Don't you have a DevOps champion to do that ? |
| sequence_number: 1, | ||
| }; | ||
|
|
||
| bus.publish(&store_event).await; |
There was a problem hiding this comment.
It is not clear to me if bus.publish(&store_event).await; is automatically called by some part of the library or if we expect the library user to call it (I guess I got lost in in the changes of this series of prs 😓). Would it make sense to add an example for the event bus flow?
There was a problem hiding this comment.
I've already added that in another PR :)
There was a problem hiding this comment.
Ok 👍. So I will wait to see all together.
cottinisimone
deleted the
PLATFORM-1085/task/add-some-event-bus-specific-impl
branch
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-1085