[REFACTOR] 영화 상세정보 배너처럼 주가 데이터 내려주기 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake1152
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
파일명 형식이 nest에서 주로 쓰이는 케밥 케이스로 되면 어떨까 싶습니다..!
src/stocks/stocks.service.ts
Outdated
| company.tickerName, | ||
| movie.movieOpenDate, | ||
| ); | ||
|
|
||
| return { | ||
| beforePriceDate: fourWeeksBeforeStock.stockDate, | ||
| beforePrice: parseFloat(fourWeeksBeforeStock.closePrice), |
There was a problem hiding this comment.
다른 곳에서는 Number()로 캐스팅하고 있습니다
추후에 parseFloat()랑 Number() 중에 하나로 통일이 필요해 보입니다.
이 글을 이슈로 빼둘게요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷
💬리뷰 요구사항(선택)