Remove fallback when changing the type instead of using an effect #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1himself
reviewed
Aug 8, 2024
packages/slate-editor/src/extensions/variables/VariableMenu.tsx
Outdated
Show resolved
Hide resolved
kudlajz
deleted the
fix/dev-13267-dont-use-null-as-a-possible-value-for-fallback
branch
e1himself
reviewed
Aug 8, 2024
| const newOption = options.find(({ value }) => value === newType); | ||
| if (newOption && !newOption.withFallback) { | ||
| updateVariable(editor, { fallback: '' }); | ||
| } else { | ||
| updateVariable(editor, { key: newType }); |
There was a problem hiding this comment.
You've forgot to add key: newType in the first branch of the if :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the feedback in #562 (comment).