New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-12552] Feature - Show pencil next to the caption & truncate if needed #530

Merged

kudlajz merged 1 commit into main from feature/dev-12552-is-it-possible-to-truncate-captions-with-dots-when-not-being

Feb 28, 2024

Contributor

kudlajz commented Feb 28, 2024 •

edited

Loading

caption is rendered as a ghost button by default, with pencil and truncation
when clicked, button changes into an input with the same styling to allow editing
introduced intermediary state for caption as using the caption prop directly causes the input to rerender on every update, causing a bug that moves the caret to the end of the input

Screenshot 2024-02-28 at 11 56 56


          Show pencil next to the caption, truncate if needed, fixed cursor mov…

68e1e9e

…ing to the end when editing a caption

kudlajz self-assigned this

kudlajz merged commit 301bc9d into main

9 checks passed

kudlajz deleted the feature/dev-12552-is-it-possible-to-truncate-captions-with-dots-when-not-being branch

February 28, 2024 11:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet