[DEV-12566] Feature - Implement GalleryBookmark extension #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kudlajz
force-pushed
the
feature/dev-12566-implement-media-gallery-picker-in-the-editor
branch
from
221648f to
9a5e471
Compare
kudlajz
changed the base branch from
main
to
feature/dev-12522-try-to-make-drag-drop-work-in-the-gallery-block
kudlajz
commented
Feb 27, 2024
|
|
||
| export const EXTENSION_ID = 'GalleryBookmarkExtension'; | ||
|
|
||
| export const GalleryBookmarkExtension = (): Extension => ({ |
There was a problem hiding this comment.
The extension feels kinda useless here since it doesn't provide anything and we're using web bookmarks under the hood.
The only thing is the createGalleryBookmark function, but I was thinking if it would be easier to just place it inline to the GalleryBookmarkPlaceholderElement and get rid of this whole extension? 🤔
Base automatically changed from
feature/dev-12522-try-to-make-drag-drop-work-in-the-gallery-block
to
main
February 27, 2024 14:28
kudlajz
deleted the
feature/dev-12566-implement-media-gallery-picker-in-the-editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension similar to Story bookmarks that allows the user to select an existing gallery and creates a web bookmark for it with some predefined options (like layout).