[CARE-1320] Fix - Editor crashing when there is a node with children: []
#412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed do satisfy Slate internal expectations
as it hits the editor performance too hard
e1himself
force-pushed
the
fix/care-1320-something-is-wrong-error
branch
from
f84e890 to
4d82fde
Compare
mohammadxali
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a built-in normalization in
slateto make surechildrenarrays always have at least one child. However, it is not triggered for the initial render. And if for any reason it happens that a node withchildren: []is saved to the database, there is no escape from it anymore.This change makes sure that the initial value does comply with this constraint.
Related
slateissue: