Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MT-4401] Chore - Upgrade Slate to v0.66 #32

Merged
merged 15 commits into from
Oct 21, 2021

Conversation

e1himself
Copy link
Contributor

No description provided.

@e1himself e1himself self-assigned this Oct 19, 2021
@linear
Copy link

linear bot commented Oct 19, 2021

@e1himself e1himself changed the base branch from master to chore/upgrade-slate-v0.62.1 October 19, 2021 16:38
@e1himself e1himself marked this pull request as draft October 19, 2021 16:39
Base automatically changed from chore/upgrade-slate-v0.62.1 to master October 20, 2021 11:00
There's a slight change in behavior, but we accept it.
There's a slight change in behavior, but we accept it.
To be sure that createHandleEditImage() still works as expected,
as it relies on inserting new empty paragraphs.
There's a slight change in behavior, but we accept it.
There's a slight change in behavior, but we accept it.
There's a slight change in behavior, but we accept it.

Also there was a regression in how slate handles void nodes in 0.63,
but then it was fixed somewhere between 0.63 and 0.66.
See ianstormtaylor/slate#3990
@e1himself e1himself changed the title [MT-4321] Chore - Upgrade Slate to v0.65 [MT-4321] Chore - Upgrade Slate to v0.66 Oct 20, 2021
@e1himself e1himself marked this pull request as ready for review October 20, 2021 12:24
@e1himself e1himself changed the title [MT-4321] Chore - Upgrade Slate to v0.66 [MT-4401] Chore - Upgrade Slate to v0.66 Oct 20, 2021
@linear
Copy link

linear bot commented Oct 20, 2021

Copy link
Contributor

@kamilmielnik kamilmielnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉 💪

lerna.json Outdated Show resolved Hide resolved
Copy link
Contributor

@kamilmielnik kamilmielnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@e1himself e1himself merged commit a8dc887 into master Oct 21, 2021
@e1himself e1himself deleted the chore/mt-4321-upgrade-slate-to-v0.65 branch October 21, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants