[DEV-2184] [@prezly/slate-renderer] Prevent the same embed scripts being loaded multiple times #18
Conversation
| @@ -13,12 +13,20 @@ const injectOembedMarkup = ({ oembed, onError, target }: Parameters): void => { | |||
| container.innerHTML = oembed.html || ''; | |||
| const embedScripts = Array.from(container.getElementsByTagName('script')); | |||
|
|
|||
| const currentScriptSources = Array.from(document.getElementsByTagName('script')).map((script) => | |||
There was a problem hiding this comment.
this comment is in an unrelated place
https://linear.app/prezly/issue/DEV-2184#comment-826b8e56
Though I couldn't find a way to test that it indeed works. I believe I will have to wait for @kamilmielnik to return and help with that
Yes, there is no easy way to test it. I've created an issue for it: #21
What you can do now is:
- Set up the
slaterepository locally - Make sure to build it
- Use local path (
file:) inpackage.jsonof your project to specify path to@prezly/slate-rendererpackage you've built locally - see npm docs
There was a problem hiding this comment.
Thanks for a tip, will try to test it like that!
| copyScriptAttributes(embedScript, script); | ||
| script.addEventListener('error', onError); | ||
| // Prevent same scripts from loading multiple times | ||
| if (!currentScriptSources.includes(embedScript.getAttribute('src'))) { |
There was a problem hiding this comment.
❌
So I have to admit to a terrible overlook from my side... I realized it only after reading your comment in linear 🤦♂️ .
Please create an html file with the following content and open it in your browser. Then open up developer tools, refresh the page and answer this question: how many times has https://cdn.jsdelivr.net/lodash/4/lodash.min.js been loaded?
<!DOCTYPE html>
<html>
<head>
<script src="https://cdn.jsdelivr.net/lodash/4/lodash.min.js"></script>
<script src="https://cdn.jsdelivr.net/lodash/4/lodash.min.js"></script>
</head>
<body>
<script src="https://cdn.jsdelivr.net/lodash/4/lodash.min.js"></script>
<script src="https://cdn.jsdelivr.net/lodash/4/lodash.min.js"></script>
</body>
</html>There was a problem hiding this comment.
Yeah, it's loaded only one time 🤔
So the I guess this PR can be safely discarded :)
Attempted fix for this issue:
https://linear.app/prezly/issue/DEV-2184/errors-in-console-when-browsing-a-page-with-multiple-videos