Windows AppData paths correction in wipe #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows Vista (>=6.0) introduced the AppData folder, while 2003 and below (<=5.2) used Application Data. Thus, it seems like these two should be swapped.
|
Looks like you're right. It also looks like the right path for < 5.2 should be "Local Settings/Application Data", right? |
|
For local data, yes. Is roaming data (<=5.2: home/Application Data, >=6.0: home/AppData/Roaming) something that should be targeted as well? |
|
@lemavri What do you think? |
|
+1 to the AppData folder fix. Also, given that the Outlook user files might be stored in AppData/Roaming, it seems like a good idea to add it to the list of paths. |
|
@hantwister's pull request is right.
Also, 👍 to @lemavri's comment. Roaming should also be deleted by Wipe. |
|
I'd say we can merge this and then add Roaming in a new PR right away. @tomas? |
|
Amen brothers! 👍 |
mauricioschneider
added a commit
that referenced
this pull request
Mar 3, 2015
Windows AppData paths correction in wipe
|
Done! Thanks @hantwister 💥 |
|
Thanks, @hantwister! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Vista (>=6.0) introduced the AppData folder, while 2003 and below (<=5.2) used Application Data. Thus, it seems like these two lines should be swapped.