Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check location setting through status.json endpoint #417

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Conversation

javo
Copy link
Contributor

@javo javo commented Mar 25, 2019

Check location aware setting with the /status.json endpint instead of sending empty location data {}

@patriciojofre
Copy link
Member

👍
buena buena

@javo
Copy link
Contributor Author

javo commented Mar 25, 2019

@michelson era parte de una prueba, estaba teniendo problemas con la última versión de sqlite, ya está reversado.

@michelson
Copy link
Contributor

comentario aparte, creo que la dependencia de sqlite es mucho para lo que en realidad se utiliza. Hay soluciones que son mas livianas y no tienen dependencias nativas

@javo
Copy link
Contributor Author

javo commented Mar 25, 2019

hasta ahora las soluciones que he experimentado constituyen guardar la información en texto plano, el cual es fácilmente corrompible (motivo por el que optamos por sqlite). De todas formas podemos re-inspeccionar otras soluciones a ver si existe una mejor actualmente :)

@javo javo merged commit 66b15c4 into master Mar 25, 2019
@javo javo deleted the location-status-fix branch July 23, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants