Client API refactor #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does is to put all the connection logic between client/server handled through a single place (/lib/api), instead of having it dispersed and implemented in each of the drivers and transports/endpoints. This way, future changes to endpoints or paths will be much simpler to manage. This simplifies a lot the code for the different drivers, and it greatly helps when it comes to error handling.
Specs were updated so we're still passing 100% -- although we still need to cover some very important things, such as switching drivers or handling different configuration scenarios (updating with older client, etc).