Filebrowser dev #184
Merged
Filebrowser dev #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient into filebrowser-dev
|
|
||
| ////////////////////////////////////////// | ||
| // Prey JS FileRetrieval | ||
| // (c) 2015 - Fork Ltd. |
|
|
||
| ////////////////////////////////////////// | ||
| // Prey JS FileRetrieval | ||
| // Sign as 2016 - Prey, Inc. |
There was a problem hiding this comment.
Replace Sign as 2016 - Prey, Inc. with (C) 2016 Prey, Inc.
| } | ||
| storage.set(NAMESPACE + id, opts); | ||
| } | ||
| else |
There was a problem hiding this comment.
This shouldn't be neccesary
| files = require('./files_storage'), | ||
| EventEmitter = require('events').EventEmitter; | ||
|
|
||
| var common = require('./../../common'), |
There was a problem hiding this comment.
all require calls should be in one var group and non require calls should be in a different var group
// First group
var a = require('a'),
b = require('b');
// Second group
var something_with_a = a.foo(),
something_with_b = b.bar();
|
👏 Congrats on your first really-big PR! As the feature is still in beta, we can proceed with merging, BUT, take note of the following requirements for the next minor:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for fileretrieval including depth and maxBuffer