Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command persistence. fix #133, fix #127 #142

Merged
merged 8 commits into from
Jul 17, 2015
Merged

Command persistence. fix #133, fix #127 #142

merged 8 commits into from
Jul 17, 2015

Conversation

mauricioschneider
Copy link
Contributor

This PR adds the following:

  • The report command is persisted when the command signature is something like {command: 'get', target: 'report', options: {interval: 5, exclude: ['picture']}}.
  • Control-panel plugin now takes into consideration the exclusions (picture and/or screenshot) when receiving missing instructions through the status.json end-point.

@mauricioschneider mauricioschneider added this to the 1.4.0 milestone Jul 14, 2015
@raliste
Copy link
Contributor

raliste commented Jul 14, 2015

Missing specs

@mauricioschneider mauricioschneider changed the title Command persistence WIP: Command persistence Jul 15, 2015
@mauricioschneider mauricioschneider changed the title WIP: Command persistence Command persistence Jul 17, 2015
@mauricioschneider mauricioschneider changed the title Command persistence Command persistence. fix #133, fix #127 Jul 17, 2015
raliste
raliste reviewed Jul 17, 2015
View reviewed changes
lib/agent/plugins/control-panel/test/main_load.js

})
it('callsback no errors', function(done) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it callback with no errors ?

@raliste
Copy link
Contributor

raliste commented Jul 17, 2015

LGTM

mauricioschneider added a commit that referenced this pull request Jul 17, 2015
@mauricioschneider
Merge pull request #142 from prey/command-persistence
8efb4e0 
Command persistence. fix #133, fix #127
@mauricioschneider mauricioschneider merged commit 8efb4e0 into master Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mauricioschneider @raliste