Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native geolocation as main geoloc strategy. #139

Merged
merged 25 commits into from
Jul 14, 2015

Conversation

mauricioschneider
Copy link
Contributor

This is a rebased version of the location branch.

TODO

  • Fallback to alternative geoloc strategy (not GeoIP, which sucks)
  • Big G geoloc specs
  • Native Geoloc specs
  • GeoIP specs
  • Preliminary build + QA

devlog:

whereami is not prompting user to give permissions to access the location when ran from Prey. Perhaps we need to add it manually by running defaults write /var/db/locationd/clients.plist in the post_install script.

@mauricioschneider mauricioschneider self-assigned this Jul 3, 2015
@mauricioschneider mauricioschneider added this to the 1.4.1 milestone Jul 3, 2015
@mauricioschneider mauricioschneider modified the milestones: 1.4.1, 1.4.0 Jul 14, 2015
};
function handle_version_error(method_name, versions) {
var err_msg = "Cannot run" + method_name + ". Invalid versions: ";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary lines 55 and 57


cb(new Error('CoreLocation not suppored in OSX ' + version))
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

@mauricioschneider
Copy link
Contributor Author

@raliste done!

@raliste
Copy link
Contributor

raliste commented Jul 14, 2015

Nice 👍

mauricioschneider added a commit that referenced this pull request Jul 14, 2015
Add native geolocation as main geoloc strategy.
@mauricioschneider mauricioschneider merged commit 47b1f5d into master Jul 14, 2015
@mauricioschneider mauricioschneider deleted the rebased-location branch July 14, 2015 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants