1.4.0-rc #131
Merged
1.4.0-rc #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cp = require('child_process'), | ||
| whenever = require('whenever'), | ||
| is_greater_than = require('./agent/helpers').is_greater_than, | ||
|
|
There was a problem hiding this comment.
This extra linebreak looks kinda weird. Everything else looks good.
There was a problem hiding this comment.
Woops, that was unintentional.
|
@tomas removed. Good to go? |
|
I think you forgot to include the helpers.js test in the repo. Apart from that, fire away. |
|
Good catch! There it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the client verifies if the latest version is higher than the current. Due to an error in the previous implementation, "1.3.10" was considered lower than "1.3.9", disabling the auto-update feature.
It also bumps the version to 1.4.0 to ensure the current 1.3.9 clients update, hence getting the fix mentioned above.