escape emojis when encodeUriCOmponent on geo

[michelson]

it seems that ssid with emojis are generating errors when the url is encoded:

 critical Tue, 07 Apr 2015 16:28:27 GMT UNCAUGHT EXCEPTION: URI malformed
 debug Tue, 07 Apr 2015 16:28:27 GMT URIError: URI malformed

the offending line is in geo/index.js 40

var str = 'wifi=mac:' + ap.mac_address + '|ssid:' + encodeURIComponent(ap.ssid);

I tried to escape the the ssid and it works , but the emoji is removed.

var str = 'wifi=mac:' + ap.mac_address + '|ssid:' + encodeURIComponent(escape(ap.ssid));

[tomas]

What OS? AFAIR we were sanitizing SSID names on get_access_points_list.

[mauricioschneider]

Here's how to reproduce:

The original SSID for testing is: 👍💓la mejor wifa

[mauricioschneider]

[mauricioschneider]

Here's some info on the proposed solution by @michelson

http://ecmanaut.blogspot.com/2006/07/encoding-decoding-utf8-in-javascript.html

[tomas]

We are, indeed, removing weird chars when parsing the output from the system command. Or at least we're trying to:

https://github.com/prey/prey-node-client/blob/master/lib/agent/providers/network/windows.js#L102
https://github.com/prey/prey-node-client/blob/master/lib/agent/providers/network/mac.js#L67
https://github.com/prey/prey-node-client/blob/master/lib/agent/providers/network/linux.js#L107

[mauricioschneider]

After some debugging, @tomas found out that what's causing the problem is that the regex is missing the g modifier.

[mauricioschneider]

According to my testings, this is only reproducible in Mac OS X. Linux and Windows are escaping the emojis correctly.