Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When getter.commands fails, stops scheduling requests. #101

Closed
mauricioschneider opened this issue Mar 17, 2015 · 0 comments · Fixed by #103
Closed

When getter.commands fails, stops scheduling requests. #101

mauricioschneider opened this issue Mar 17, 2015 · 0 comments · Fixed by #103
Labels
bug priority: critical

Comments

@mauricioschneider
Copy link
Contributor

This was reported by @tomas yesterday.

In interval/index.js, if getter.commands fails for any reason, then the cb is returned and schedule_request is never reached, hence, stopping the requests scheduling.
mauricioschneider added a commit that referenced this issue Mar 17, 2015
@mauricioschneider
CP: Schedule request before handling possible request errors. Fix #101
77e0c61
@mauricioschneider mauricioschneider mentioned this issue Mar 18, 2015
Merged
3 tasks
mauricioschneider added a commit that referenced this issue Mar 19, 2015
@mauricioschneider
Update test cases to cover issue #101.
7d64ef7
mauricioschneider added a commit that referenced this issue Apr 24, 2015
@mauricioschneider @tomas
CP: Schedule request before handling possible request errors. Fix #101
9b9d5d5
mauricioschneider added a commit that referenced this issue Apr 24, 2015
@mauricioschneider @tomas
Update test cases to cover issue #101.
ddc481b
mauricioschneider added a commit that referenced this issue Jul 1, 2015
@mauricioschneider
CP: Schedule request before handling possible request errors. Fix #101
ef31a90
mauricioschneider added a commit that referenced this issue Jul 1, 2015
@mauricioschneider
Update test cases to cover issue #101.
88e7cbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority: critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1.3.8-rc prey/prey-node-client
1 participant
@mauricioschneider