Improve error messages #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upper version from python 3.6 requires to compare using `==` or `!=` when comparing againts literal strings or numbers, it also requires to use the work `as` on exceptions, and use the parenthesis when calling the method `print`. This also fixes the tests to be case sensitive when using unix/linux.
Currently we are raising a HTTPError using the method `raise_for_status` from the `Requests` library, this doesn't takes the information returned from the API with the explaination of why the API could not create the file, instead we are parsing the response from the API and raising an `Exception` with the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix python 3.6+ issues
Upper version from python 3.6 requires to compare using
==or!=when comparing againts literal strings or numbers, it also requires
to use the work
ason exceptions, and use the parenthesis whencalling the method
print. This also fixes the tests to be casesensitive when using unix/linux.
Improve error messages
Currently we are raising a HTTPError using the method
raise_for_statusfrom the
Requestslibrary, this doesn't takes the informationreturned from the API with the explaination of why the API could
not create the file, instead we are parsing the response from the
API and raising an
Exceptionwith the error.Fixes #3