Fix the return type of format: string -> Promise<string> #751
Conversation
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 2 2
Lines 298 298
Branches 88 88
=======================================
Hits 297 297
Misses 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
This is great but your commit message needs to follow the convention of conventional commits since we use semantic-release to handle our release versioning. https://www.conventionalcommits.org/
Could you please fix the commit message?
The return type was not updated when format function was changed to an async function. This patch changes the type from `string` to `Promise<string>`, this only affects language servers.
IronBlood
force-pushed
the
fix/return-type-of-format
branch
from
ae3227c to
841590e
Compare
|
Sorry for making troubles, this is my first time of learning the concept of Conventional Commits. Does the commit message now look good? |
|
🎉 This PR is included in version 15.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The function declaration was changed in #696 from
function format(options)toasync function(options), the example section in README.md is changed as well, but the doc as well as the later addedtypes/index.d.tsfrom #739 was not updated.