Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump all upgradable (dev)Dependencies except pure ESM #437

Merged
merged 8 commits into from
Aug 12, 2022
Merged

feat!: bump all upgradable (dev)Dependencies except pure ESM #437

merged 8 commits into from
Aug 12, 2022

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Aug 11, 2022

close

What:

Maintenance

Why:

The (dev)Dependencies are very outdated

How:

  1. Bump all upgradable (dev)Dependencies except pure ESM ones
  2. Upgrade GitHub Actions versions and related usage
  3. Enable CI workflow for pull_request events
  4. Replace husky with simple-git-hooks which is much easier to use, you may need to run git config --unset core.hooksPath if you've enabled husky@v2+ previously
  5. Remove cli-test task (which is buggy) in favor of test including cli.spec already, now npm start validate is just working as expected
  6. Use eslint-plugin-node-dependencies to ensure we have correct versions range of dependencies
  7. Enable CodeSandbox CI for testing before releasing easily

I will start to migrate to pure ESM later

@JounQin JounQin changed the title feat: bump all upgradable (dev)Dependencies except pure ESM feat!: bump all upgradable (dev)Dependencies except pure ESM Aug 12, 2022
@JounQin JounQin mentioned this pull request Aug 12, 2022
package.json Outdated Show resolved Hide resolved
patches/@rushstack+eslint-patch+1.1.4.patch Show resolved Hide resolved
test/tests/cli.spec.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
.nvmrc Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #437 (eb8e934) into master (04a8e04) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #437   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          157       161    +4     
  Branches        23        27    +4     
=========================================
+ Hits           157       161    +4     
Impacted Files Coverage Δ
src/format-files.js 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JounQin JounQin requested a review from idahogurl August 12, 2022 03:07
@lydell lydell removed their request for review August 12, 2022 07:04
Copy link
Collaborator

@kylemh kylemh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me

@JounQin
Copy link
Member Author

JounQin commented Aug 12, 2022

@kylemh @lydell

Don you have permissions to install GitHub Apps on this repository? I'd like to install https://ci.codesandbox.io to address #424 (comment)

@kylemh
Copy link
Collaborator

kylemh commented Aug 12, 2022

Go for it. We're all in charge here.

@JounQin
Copy link
Member Author

JounQin commented Aug 12, 2022

Go for it. We're all in charge here.

Did you receive my request? I sent it a few days ago and just send the request again.

@lydell
Copy link
Member

lydell commented Aug 12, 2022

I don’t have access. I have very few permissions in the repo, it looks like.

@JounQin
Copy link
Member Author

JounQin commented Aug 12, 2022

cc @prettier/core

@fisker
Copy link
Member

fisker commented Aug 12, 2022

image
image

Is this what you need?

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin JounQin merged commit 25fcce1 into prettier:master Aug 12, 2022
@JounQin JounQin deleted the feat/deps branch August 12, 2022 15:00
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants