-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VSCode setup instructions #867
Add VSCode setup instructions #867
Conversation
ec69d13
to
c139f1e
Compare
c139f1e
to
89f7767
Compare
README.md
Outdated
{ | ||
"[ruby]": { | ||
"editor.defaultFormatter": "esbenp.prettier-vscode", | ||
"editor.formatOnSave": true // optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// optional
isn't valid json and messes up syntax highlighting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's valid in VS Code's settings config but I'll remove it.
Co-authored-by: Paul-Etienne Coisne <[email protected]>
Thanks for this, I thrashed around a lot with the npm package vs the gem as well. I was wondering whether there should also be instructions for how this interacts with the Ruby VSCode extension https://marketplace.visualstudio.com/items?itemName=rebornix.Ruby I would imagine a lot of people have that installed as well. I THINK I finally got everybody playing nice together by adding
To the VSCode config or maybe just remove it altogether. Before I had
Edit: Maybe |
Just chiming in to say that I followed the steps in this PR and I'm VERY happy with the results! Thanks very much! |
I'd love to see this in the |
I had a lot trouble getting prettier working with VS Code. Initially I was trying to use the Ruby gem, but it seems the npm library is a better choice.
The approach I describe is based on @coisnepe's comment in #113.