added dangling commas on multiline attributes (#1886)

fixes #1884

src/printer.js

@@ -635,7 +635,9 @@ function printArgumentsList(path, options, print, argumentsKey = "arguments") {
     (shouldPrintComma(options, "7.3") &&
       ["call", "new", "unset", "isset"].includes(node.kind)) ||
     (shouldPrintComma(options, "8.0") &&
-      ["function", "closure", "method", "arrowfunc"].includes(node.kind))
+      ["function", "closure", "method", "arrowfunc", "attribute"].includes(
+        node.kind
+      ))
       ? indent(
           concat([
             lastArg && shouldPrintHardlineBeforeTrailingComma(lastArg)
@@ -1231,6 +1233,7 @@ function printAttrs(path, options, print, { inline = false } = {}) {
       group(
         concat([
           indent(concat(attrGroup)),
+          ifBreak(shouldPrintComma(options, "8.0") ? "," : ""),
           ifBreak(softline),
           "]",
           softline,
@@ -2225,7 +2228,7 @@ function printNode(path, options, print) {
               ])
             : "",
           ...path.call(
-            (pa, opt, pr) => printAttrs(pa, opt, pr, { inline: true }),
+            (pa) => printAttrs(pa, options, print, { inline: true }),
             "what"
           ),
           "class",

tests/attributes-trail-comma/__snapshots__/jsfmt.spec.js.snap

@@ -0,0 +1,57 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`attributes-trail-comma.php 1`] = `
+====================================options=====================================
+parsers: ["php"]
+phpVersion: "8.0"
+printWidth: 80
+trailingCommaPHP: true
+                                                                                | printWidth
+=====================================input======================================
+<?php
+
+#[W('a', null, 'looooong','paraaaams','list','aaaaaaaaaaaaa','vvvvvvvvvvvv','cccccccccc','eeeeeeeeeee'), X()]
+final class ORM
+{
+
+    #[
+        ORM\\Column,
+        ORM\\CustomIdGenerator(class: "bar"),
+        ORM\\GeneratedValue(strategy: 'CUSTOM'),
+        ORM\\Id
+    ]
+    private string $id;
+}
+
+=====================================output=====================================
+<?php
+
+#[
+    W(
+        "a",
+        null,
+        "looooong",
+        "paraaaams",
+        "list",
+        "aaaaaaaaaaaaa",
+        "vvvvvvvvvvvv",
+        "cccccccccc",
+        "eeeeeeeeeee",
+    ),
+    X,
+]
+
+final class ORM
+{
+    #[
+        ORM\\Column,
+        ORM\\CustomIdGenerator(class: "bar"),
+        ORM\\GeneratedValue(strategy: "CUSTOM"),
+        ORM\\Id,
+    ]
+
+    private string $id;
+}
+
+================================================================================
+`;

tests/attributes-trail-comma/attributes-trail-comma.php

@@ -0,0 +1,14 @@
+<?php
+
+#[W('a', null, 'looooong','paraaaams','list','aaaaaaaaaaaaa','vvvvvvvvvvvv','cccccccccc','eeeeeeeeeee'), X()]
+final class ORM
+{
+
+    #[
+        ORM\Column,
+        ORM\CustomIdGenerator(class: "bar"),
+        ORM\GeneratedValue(strategy: 'CUSTOM'),
+        ORM\Id
+    ]
+    private string $id;
+}

tests/attributes-trail-comma/jsfmt.spec.js

@@ -0,0 +1 @@
+run_spec(__dirname, ["php"], { trailingCommaPHP: true, phpVersion: "8.0" });