Addes support for final class const (#2186)

* Addes support for final class const Fixes #2183 * Update snapshots * chore: update parser to 3.1.5 --------- Co-authored-by: Christian Zosel <[email protected]>
prettier · Jun 11, 2023 · 29f3706 · 29f3706
1 parent 39c4d52
commit 29f3706
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
   "dependencies": {
     "linguist-languages": "^7.21.0",
     "mem": "^8.0.0",
-    "php-parser": "^3.1.3"
+    "php-parser": "^3.1.5"
   },
   "devDependencies": {
     "@babel/preset-env": "^7.19.4",

diff --git a/src/printer.js b/src/printer.js
@@ -2377,6 +2377,7 @@ function printNode(path, options, print) {
 
       return group([
         ...attrs,
+        node.final ? "final " : "",
         node.visibility ? [node.visibility, " "] : "",
         "const",
         firstVariable ? [" ", firstVariable] : "",

diff --git a/tests/class/__snapshots__/jsfmt.spec.js.snap b/tests/class/__snapshots__/jsfmt.spec.js.snap
@@ -940,6 +940,8 @@ readonly class ReadOnlyCls {
     public string $myValue;
 }
 
+class FinalCost { final public const FOO = 'foo'; }
+
 =====================================output=====================================
 <?php
 
@@ -1466,5 +1468,10 @@ readonly class ReadOnlyCls
     public string $myValue;
 }
 
+class FinalCost
+{
+    final public const FOO = "foo";
+}
+
 ================================================================================
 `;
diff --git a/tests/class/class.php b/tests/class/class.php
@@ -304,3 +304,5 @@ public function __construct(   public  int $a, private float $b, protected  stri
 readonly class ReadOnlyCls {
     public string $myValue;
 }
+
+class FinalCost { final public const FOO = 'foo'; }
diff --git a/yarn.lock b/yarn.lock
@@ -4276,10 +4276,10 @@ path-type@^4.0.0:
   resolved "https://registry.yarnpkg.com/path-type/-/path-type-4.0.0.tgz#84ed01c0a7ba380afe09d90a8c180dcd9d03043b"
   integrity sha512-gDKb8aZMDeD/tZWs9P6+q0J9Mwkdl6xMV8TjnGP3qJVJ06bdMgkbBlLU8IdfOsIsFz2BW1rNVT3XuNEl8zPAvw==
 
-php-parser@^3.1.3:
-  version "3.1.3"
-  resolved "https://registry.yarnpkg.com/php-parser/-/php-parser-3.1.3.tgz#7a2aac2eb88a5a6c5aa75e6170a256bee5a30e6b"
-  integrity sha512-hPvBmnRYPqWEtMfIFOlyjQv1q75UUtxt4U+YscKIQViGmEE2Xa4BuS1B1/cZdjy7MVcwtnr0WkEsr915LgRKOw==
+php-parser@^3.1.5:
+  version "3.1.5"
+  resolved "https://registry.yarnpkg.com/php-parser/-/php-parser-3.1.5.tgz#84500e5b5c6a0907e32c38b931bb4e7d3f275026"
+  integrity sha512-jEY2DcbgCm5aclzBdfW86GM6VEIWcSlhTBSHN1qhJguVePlYe28GhwS0yoeLYXpM2K8y6wzLwrbq814n2PHSoQ==
 
 picocolors@^1.0.0:
   version "1.0.0"