Support < and > prefixes for high and low bytes in VC patch templates
#1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works perfectly in Narishma-gb/pokegreen@10335f1, thanks! I'll sync green (and blue) when this is merged in pokered. |
vulcandth
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed for pokecrystal (nor for pokegold, pokered, or pokeyellow), but it is needed for Narishma-gb/pokegreen@24ad50f. @Narishma-gb Can you please review this and verify that it works for you? The syntax is based on what some other assemblers besides RGBASM have used for low/high bytes, and it's easier to parse than
LOW()/HIGH(). So in pokegreen,LOW(Subanim_1StarBigMoving+7)would become<Subanim_1StarBigMoving+7.