Use Hive Text instead of Java String in GenericHiveRecordCursor #8206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
force-pushed
the
generic-hive-reader-avoid-string
branch
2 times, most recently
from
6f90eef to
6580472
Compare
electrum
approved these changes
Jun 7, 2017
dain
force-pushed
the
generic-hive-reader-avoid-string
branch
from
6580472 to
e4dfc8e
Compare
This was referenced Sep 11, 2020
pettyjamesm
added a commit
to pettyjamesm/prestodb
that referenced
this pull request
Sep 15, 2020
Introduced in prestodb#8206, GenericHiveRecordCursor was modified to avoid extra overhead when the SerDe provided a more efficient String handling implementation with Writables. However, when the SerDe does not provide such an implementation and instead already returned String instances directly, this change introduced an extra conversion from bytes to String just to be converted back to bytes. This change alters the behavior of GenericHiveRecordCursor parseString to respect the PrimitiveObjectInspector's preference for using writables.
mbasmanova
pushed a commit
that referenced
this pull request
Sep 17, 2020
Introduced in #8206, GenericHiveRecordCursor was modified to avoid extra overhead when the SerDe provided a more efficient String handling implementation with Writables. However, when the SerDe does not provide such an implementation and instead already returned String instances directly, this change introduced an extra conversion from bytes to String just to be converted back to bytes. This change alters the behavior of GenericHiveRecordCursor parseString to respect the PrimitiveObjectInspector's preference for using writables.
shangxinli
pushed a commit
to shangxinli/presto
that referenced
this pull request
Nov 18, 2020
Introduced in prestodb#8206, GenericHiveRecordCursor was modified to avoid extra overhead when the SerDe provided a more efficient String handling implementation with Writables. However, when the SerDe does not provide such an implementation and instead already returned String instances directly, this change introduced an extra conversion from bytes to String just to be converted back to bytes. This change alters the behavior of GenericHiveRecordCursor parseString to respect the PrimitiveObjectInspector's preference for using writables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.