Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 0.226 #13411

Merged
merged 1 commit into from
Sep 21, 2019

Conversation

neeradsomanchi
Copy link
Contributor

@neeradsomanchi neeradsomanchi commented Sep 17, 2019

Reference issue: #13340

== NO RELEASE NOTE ==

Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neeradsomanchi Thanks for putting this together. Here are some comments.

presto-docs/src/main/sphinx/release/release-0.226.rst Outdated Show resolved Hide resolved
* Fix ST_Buffer for tiny geometries (#13194)
* Fix ST_Centroid for tiny geometries (#10629)
* Fix bug that causes failure when reading unpartitioned table from some connectors with session property ``grouped_execution_for_eligible_table_scans`` turned on.
* Reuse compression buffer in PagesSerde when serializing pages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if there is a way to describe user-visible effect of this change. Otherwise, I'd remove this. CC: @yingsu00

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yingsu00 ping

@neeradsomanchi Let's remove this note.

presto-docs/src/main/sphinx/release/release-0.226.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.226.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.226.rst Outdated Show resolved Hide resolved
@neeradsomanchi
Copy link
Contributor Author

Addressed comments.

Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neeradsomanchi Looks good to me % a couple of comments.

presto-docs/src/main/sphinx/release/release-0.226.rst Outdated Show resolved Hide resolved
* Fix ST_Buffer for tiny geometries (#13194)
* Fix ST_Centroid for tiny geometries (#10629)
* Fix bug that causes failure when reading unpartitioned table from some connectors with session property ``grouped_execution_for_eligible_table_scans`` turned on.
* Reuse compression buffer in PagesSerde when serializing pages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yingsu00 ping

@neeradsomanchi Let's remove this note.

@neeradsomanchi
Copy link
Contributor Author

Screen Shot 2019-09-19 at 2 29 40 PM

Release notes look like this.

Copy link
Contributor

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rschlussel
Copy link
Contributor

Also, I'm heading home for the day, but I have no other comments after those changes.

@neeradsomanchi
Copy link
Contributor Author

Addressed comments, thanks @rschlussel !

@mbasmanova mbasmanova merged commit 6a0db15 into prestodb:master Sep 21, 2019
@neeradsomanchi neeradsomanchi deleted the release-notes-0.226 branch September 21, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants