Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grouped execution tagging for table scan #13329

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Fix grouped execution tagging for table scan #13329

merged 1 commit into from
Sep 4, 2019

Conversation

shixuan-fan
Copy link
Contributor

@shixuan-fan shixuan-fan commented Sep 3, 2019 •
edited
Loading

Addresses #13322
We should return incapable for table scan in the following two cases:

  • TablePartitioing is empty
  • TablePartitioning is not empty but it only contains one
    NotPartitionedPartitionHandle in the partition handle list

The first case is already covered, and this commit is aiming
at fixing the second case.

== RELEASE NOTES ==

General Changes
* Fix bug that causes failure when reading unpartitioned table from some connectors with session property ``grouped_execution_for_eligible_table_scans`` turned on.

@shixuan-fan
Fix grouped execution tagging for table scan
96b4454 
We should return incapable for table scan in the following two cases:
- TablePartitioing is empty
- TablePartitioning is not empty but it only contains one
  NotPartitionedPartitionHandle in the partition handle list

The first case is already covered, and this commit is aiming
at fixing the second case.
arhimondr
arhimondr approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@arhimondr arhimondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arhimondr arhimondr merged commit c6371ab into prestodb:master Sep 4, 2019
@shixuan-fan shixuan-fan mentioned this pull request Sep 4, 2019
Closed
@neeradsomanchi neeradsomanchi mentioned this pull request Sep 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhimondr arhimondr arhimondr approved these changes

@highker highker Awaiting requested review from highker

Assignees

@highker highker

@arhimondr arhimondr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shixuan-fan @arhimondr @highker @facebook-github-bot