Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug support for offline table and partition #13312

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Add debug support for offline table and partition #13312

merged 1 commit into from
Sep 5, 2019

Conversation

wenleix
Copy link
Contributor

@wenleix wenleix commented Aug 30, 2019

Please fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.

== RELEASE NOTES ==


Hive Changes
* Add debug mode that allows reading from offline table and partition. This is controlled by session property `offline_data_debug_mode_enabled `

@wenleix wenleix force-pushed the offline_debug branch 4 times, most recently from a73c24f to 172dc66 Compare August 31, 2019 00:38
@wenleix wenleix changed the title [WIP, Test Only] Add debug support for offline table and partition Add debug support for offline table and partition Aug 31, 2019
arhimondr
arhimondr approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@arhimondr arhimondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

presto-hive/src/main/java/com/facebook/presto/hive/HivePartitionManager.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HivePartitionManager.java Outdated Show resolved Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveSessionProperties.java Outdated Show resolved Hide resolved
@wenleix wenleix merged commit ecdbbb3 into prestodb:master Sep 5, 2019
@wenleix wenleix deleted the offline_debug branch September 5, 2019 01:13
@neeradsomanchi neeradsomanchi mentioned this pull request Sep 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhimondr arhimondr arhimondr approved these changes

@rongrong rongrong Awaiting requested review from rongrong

Assignees

@rongrong rongrong

@arhimondr arhimondr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenleix @arhimondr @rongrong @facebook-github-bot