Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch.scroll-timeout example correction #13257

Merged
merged 1 commit into from
Aug 31, 2019
Merged

elasticsearch.scroll-timeout example correction #13257

merged 1 commit into from
Aug 31, 2019

Conversation

farukarakaya
Copy link
Contributor

originally mentioned here
@aweisberg

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@zhenxiao zhenxiao self-assigned this Aug 20, 2019
@zhenxiao
Copy link
Collaborator

thank you @farukarakaya
looks good. could you please sign the CLA?

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

@zhenxiao zhenxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Could you please squash the 3 commits into 1, with commit message "Fix Elasticsearch Connector scroll-timeout documentation"?

@zhenxiao zhenxiao merged commit 1dfa608 into prestodb:master Aug 31, 2019
@farukarakaya farukarakaya deleted the patch-1 branch September 1, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants