Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move classes out of root package #12322

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Move classes out of root package #12322

merged 3 commits into from
Feb 23, 2019

Conversation

wenleix
Copy link
Contributor

@wenleix wenleix commented Feb 11, 2019

Extracted-From: trinodb/trino#31

@wenleix wenleix mentioned this pull request Feb 11, 2019
Closed
tdcmeehan
tdcmeehan approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize in advance for the merge conflicts

@findepi
Copy link
Contributor

findepi commented Feb 22, 2019

Extracted-From: prestosql/presto#31

would it be possible to retain authorship?

@wenleix
Copy link
Contributor Author

wenleix commented Feb 23, 2019

@findepi : done ;)

@wenleix wenleix merged commit 1224886 into prestodb:master Feb 23, 2019
@wenleix wenleix deleted the pull_sql_root_pkg2 branch February 23, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shixuan-fan shixuan-fan shixuan-fan approved these changes

@tdcmeehan tdcmeehan tdcmeehan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wenleix @findepi @tdcmeehan @shixuan-fan @facebook-github-bot @electrum