Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LDAP with anonymous bind disabled #11714

Closed
wants to merge 2 commits into from
Closed

Support LDAP with anonymous bind disabled #11714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42aed9c
TMP use non-release yet openldap image
findepi Oct 15, 2018
77aa30d
Support LDAP with anonymous bind disabled
findepi Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions ...password-authenticators/src/main/java/com/facebook/presto/password/LdapAuthenticator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ public LdapAuthenticator(LdapConfig serverConfig)
.put(INITIAL_CONTEXT_FACTORY, "com.sun.jndi.ldap.LdapCtxFactory")
.put(PROVIDER_URL, ldapUrl)
.build();
checkEnvironment(environment);
this.basicEnvironment = environment;
this.authenticationCache = CacheBuilder.newBuilder()
.expireAfterWrite(serverConfig.getLdapCacheTtl().toMillis(), MILLISECONDS)
Expand Down Expand Up @@ -175,16 +174,6 @@ private static String replaceUser(String pattern, String user)
return pattern.replaceAll("\\$\\{USER}", user);
}

private static void checkEnvironment(Map<String, String> environment)
{
try {
closeContext(createDirContext(environment));
}
catch (NamingException e) {
throw new RuntimeException(e);
}
}

private static void closeContext(DirContext context)
{
try {
Expand Down
2 changes: 1 addition & 1 deletion presto-product-tests/conf/docker/singlenode-ldap/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ services:
- CLI_ARGUMENTS=--server https://presto-master:8443 --keystore-path /etc/openldap/certs/coordinator.jks --keystore-password testldap

ldapserver:
image: 'prestodb/centos6-oj8-openldap:${DOCKER_IMAGES_VERSION}'
image: 'prestodb/centos6-oj8-openldap:4fc1925'