Small cleanup in TeradataDateFunctions #10946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
epic/timestampp/tera-date
branch
from
da93775 to
5ad7b7c
Compare
sopel39
reviewed
Jul 2, 2018
| { | ||
| try { | ||
| long millis = parseMillis(session, dateTime, formatString); | ||
| return (long) castToDate.invokeExact(session, millis); | ||
| long millis = parseMillis(UTC_KEY, session.getLocale(), dateTime, formatString); |
There was a problem hiding this comment.
Shouldn't passing UTC_KEY/session zone depend on legacy timestamp flag?
There was a problem hiding this comment.
Shouldn't passing UTC_KEY/session zone depend on legacy timestamp flag?
DATEs have just one semantics (no legacy here)
No new tests are needed?
Tests exists and implementation was working correctly. This just simplifies.
sopel39
reviewed
Jul 2, 2018
| @@ -152,7 +147,7 @@ private void assertDate(String projection, int year, int month, int day) | |||
| assertFunction( | |||
| projection, | |||
| DateType.DATE, | |||
| sqlDate(new DateTime(year, month, day, 0, 0, DateTimeZone.UTC))); | |||
| new SqlDate(toIntExact(LocalDate.of(year, month, day).toEpochDay()))); | |||
There was a problem hiding this comment.
Shouldn't commit message be:
Fix TestTeradataDateFunctions to work with non-legacy dates and in zones with negative offset?
sopel39
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #10128