Support round long function for decimal places < 0 #10349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Apr 9, 2018
| @@ -763,14 +763,28 @@ public void testRound() | |||
|
|
|||
| assertFunction("round(TINYINT '3', TINYINT '0')", TINYINT, (byte) 3); | |||
| assertFunction("round(TINYINT '3', 0)", TINYINT, (byte) 3); | |||
| assertFunction("round(TINYINT '9', -1)", TINYINT, (byte) 10); | |||
| assertFunction("round(TINYINT '-9', -1)", TINYINT, (byte) -10); | |||
There was a problem hiding this comment.
add cases
(12, -1) → 10(18, -1) → 20
| assertFunction("round( 3000000000, 0)", BIGINT, 3000000000L); | ||
| assertFunction("round(-3000000000, 0)", BIGINT, -3000000000L); | ||
| assertFunction("round( 3999999999, -1)", BIGINT, 4000000000L); | ||
| assertFunction("round(-3999999999, -1)", BIGINT, -4000000000L); |
There was a problem hiding this comment.
add a cases
(9223372036854775807, -3)(9223372036854775807, -19)(should overflow)(9223372036854775807, -20)(9223372036854775807, -2147483648)
| assertFunction("round(-3, INTEGER '0')", INTEGER, -3); | ||
| assertFunction("round(99, INTEGER '-1')", INTEGER, 100); | ||
| assertFunction("round(-99, INTEGER '-1')", INTEGER, -100); |
There was a problem hiding this comment.
add case
(12355, -2) → 12400)(12345, -2) → 12300)(2147483647, -9) → 2000000000(2147483647, -10) → 0(2147483647, -100) → 0(2147483647, -2147483648) → 0
|
I'm sorry but I close this PR because it seems it's not simpler than my expected and I don't have much time. If I find a better way to fix, I may reopen this PR though. |
|
@ebyhr please keep this open. If you don't have the time to continue, someone may take this over. |
|
@findepi I see :) Reopened. |
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10025