Change default TIME/TIMESTAMP semantics to ANSI SQL

prestodb · Mar 10, 2017 · bf1e739 · bf1e739
1 parent c0beab7
commit bf1e739
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java b/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
@@ -58,7 +58,7 @@ public static class ProcessingOptimization
     private boolean exchangeCompressionEnabled = false;
     private boolean legacyArrayAgg;
     private boolean legacyOrderBy;
-    private boolean legacyTimestamp = true;
+    private boolean legacyTimestamp;
     private boolean legacyMapSubscript;
     private boolean optimizeMixedDistinctAggregations;
 

diff --git a/presto-main/src/main/java/com/facebook/presto/testing/TestingConnectorSession.java b/presto-main/src/main/java/com/facebook/presto/testing/TestingConnectorSession.java
@@ -51,7 +51,7 @@ public class TestingConnectorSession
 
     public TestingConnectorSession(List<PropertyMetadata<?>> properties)
     {
-        this("user", UTC_KEY, ENGLISH, System.currentTimeMillis(), properties, ImmutableMap.of(), true);
+        this("user", UTC_KEY, ENGLISH, System.currentTimeMillis(), properties, ImmutableMap.of(), false);
     }
 
     public TestingConnectorSession(

diff --git a/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java b/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java
@@ -64,7 +64,7 @@ public void testDefaults()
                 .setLegacyOrderBy(false)
                 .setIterativeOptimizerEnabled(false)
                 .setExchangeCompressionEnabled(false)
-                .setLegacyTimestamp(true)
+                .setLegacyTimestamp(false)
                 .setIterativeOptimizerTimeout(new Duration(3, MINUTES))
                 .setExchangeCompressionEnabled(false));
     }
@@ -100,7 +100,7 @@ public void testExplicitPropertyMappings()
                 .put("experimental.spiller-spill-path", "/tmp/custom/spill/path")
                 .put("experimental.spiller-threads", "42")
                 .put("exchange.compression-enabled", "true")
-                .put("deprecated.legacy-timestamp", "false")
+                .put("deprecated.legacy-timestamp", "true")
                 .build();
         Map<String, String> properties = new ImmutableMap.Builder<String, String>()
                 .put("experimental.resource-groups-enabled", "true")
@@ -130,7 +130,7 @@ public void testExplicitPropertyMappings()
                 .put("experimental.spiller-spill-path", "/tmp/custom/spill/path")
                 .put("experimental.spiller-threads", "42")
                 .put("exchange.compression-enabled", "true")
-                .put("deprecated.legacy-timestamp", "false")
+                .put("deprecated.legacy-timestamp", "true")
                 .build();
 
         FeaturesConfig expected = new FeaturesConfig()
@@ -161,7 +161,7 @@ public void testExplicitPropertyMappings()
                 .setSpillerThreads(42)
                 .setLegacyOrderBy(true)
                 .setExchangeCompressionEnabled(true)
-                .setLegacyTimestamp(false);
+                .setLegacyTimestamp(true);
 
         assertFullMapping(properties, expected);
         assertDeprecatedEquivalence(FeaturesConfig.class, properties, propertiesLegacy);

diff --git a/presto-spi/src/test/java/com/facebook/presto/spi/block/TestDictionaryBlockEncoding.java b/presto-spi/src/test/java/com/facebook/presto/spi/block/TestDictionaryBlockEncoding.java
@@ -68,7 +68,7 @@ public long getStartTime()
         @Override
         public boolean isLegacyTimestamp()
         {
-            return true;
+            return false;
         }
 
         @Override

diff --git a/presto-spi/src/test/java/com/facebook/presto/spi/block/TestVariableWidthBlockEncoding.java b/presto-spi/src/test/java/com/facebook/presto/spi/block/TestVariableWidthBlockEncoding.java
@@ -67,7 +67,7 @@ public long getStartTime()
         @Override
         public boolean isLegacyTimestamp()
         {
-            return true;
+            return false;
         }
 
         @Override