Always use fixed TIME as session base in TestDateTimeFunctions

Using this will allow to write simpler tests and avoid intermittent error caused by DST or changes in time zone policies. Without this change some test would require to rewrite to much logic from implementation making them less usefull.
prestodb · Mar 10, 2017 · 6cae932 · 6cae932
1 parent 9dc288e
commit 6cae932
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/presto-main/src/test/java/com/facebook/presto/operator/scalar/TestDateTimeFunctions.java b/presto-main/src/test/java/com/facebook/presto/operator/scalar/TestDateTimeFunctions.java
@@ -13,6 +13,7 @@
  */
 package com.facebook.presto.operator.scalar;
 
+import org.joda.time.DateTime;
 import org.testng.annotations.Test;
 
 import static com.facebook.presto.spi.StandardErrorCode.FUNCTION_NOT_FOUND;
@@ -27,6 +28,7 @@ public TestDateTimeFunctions()
                 testSessionBuilder()
                         .setTimeZoneKey(TIME_ZONE_KEY)
                         .setSystemProperty("legacy_timestamp", "false")
+                        .setStartTime(new DateTime(2017, 04, 01, 12, 34, 56, 789, UTC_TIME_ZONE).getMillis())
                         .build()
         );
     }

diff --git a/...o-main/src/test/java/com/facebook/presto/operator/scalar/TestDateTimeFunctionsLegacy.java b/...o-main/src/test/java/com/facebook/presto/operator/scalar/TestDateTimeFunctionsLegacy.java
@@ -13,6 +13,7 @@
  */
 package com.facebook.presto.operator.scalar;
 
+import org.joda.time.DateTime;
 import org.testng.annotations.Test;
 
 import static com.facebook.presto.spi.type.VarcharType.VARCHAR;
@@ -29,6 +30,7 @@ public TestDateTimeFunctionsLegacy()
                 testSessionBuilder()
                         .setTimeZoneKey(TIME_ZONE_KEY)
                         .setSystemProperty("legacy_timestamp", "true")
+                        .setStartTime(new DateTime(2017, 04, 01, 12, 34, 56, 789, UTC_TIME_ZONE).getMillis())
                         .build()
         );
     }