Webpack 4 + babel 7 final

[duGuillaume]

Babel 7 is out and this PR (#2) look dead so, here a new PR with a clean package.json and webpack.config

i use webpack 4 and babel 7.
packages have been updated.
i created an img folder into assets and removed thems from css folder.
fonts from css folder have been removed.

instead of 'npm run watch' we use 'npm start'
now .map files are create with watch command to help developpement
A new npm command have been created to help debug (can be improved)

[kpodemski]

Hey,

curious, what is your time for:

1. build
2. start
3. start, 2nd compilation

?

[duGuillaume]

sry i'm using windows wsl, I don't think it's the best config to test timers

[labsin]

Works here. Have no metrics to test this, but first build is 15s instead of 30s (on an old laptop on arch)

Should _dev/package-lock.json be removed from the PR? It's not in the repo.

[duGuillaume]

i'll make an update tonight, some packages need to be change or updated.
i think i'll remove --mode development for 'npm start' command. devtool and source-map shouldn't be here.
I need to remove uglifyjs package to use terser here from the uglifyjs-webpack-plugin changelog.

Switch back to uglify-js (uglify-es is abandoned, if you need uglify ES6 code please use terser-webpack-plugin).

@labsin I think package-lock.json should be in the repo here the doc about it: https://docs.npmjs.com/files/package-lock.json. but it's a good question, what to do with sourcemap ?

[duGuillaume]

i removed .map and update packages to use terser instead uglifyjs

[SharakPL]

what's up with the conflicts? will it be merged anytime soon?

[duGuillaume]

I ve updated packages and I'm working on the conflicts i'll make a pull request soon

[duGuillaume]

conflicts merged and packages updated

[jdziewonski]

What's up with this PR ?
I have my own updated webpack version and i'm considering creating new PR with my own solution, but it seems that this PR needs only simple merge, npm update and sources compilation.

Do @prestarocket consider that update as proper solution ? There is gulpfile.js on develop branch, and it's there only to compile sass files, but updated webpack handle it well.
If performance is to bad, maybe consider changing sass-loader to fast-sass-loader as mentioned in here

[prestarocket]

What's up with this PR ?
I have my own updated webpack version and i'm considering creating new PR with my own solution, but it seems that this PR needs only simple merge, npm update and sources compilation.

Do @prestarocket consider that update as proper solution ? There is gulpfile.js on develop branch, and it's there only to compile sass files, but updated webpack handle it well.
If performance is to bad, maybe consider changing sass-loader to fast-sass-loader as mentioned in here

could ypu make a new PR on dev.b branch, i will test it ? i m really not an expert with webpack...

[prestarocket]

finally !! 2238019

[prestarocket]

thank you, your work has helped me a lot!

[dangelion]

Is this currently merged? I still see webpack 2 here

[prestarocket]

in dev branch Le ven. 27 mars 2020 à 16:57, Dangelion <[email protected]> a écrit :

…

Is this currently merged? I still see webpack 2 here — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG3SXTDUCAXGVBZ34ADGC3RJTEF7ANCNFSM4FS7X3BA> .

-- *Dernières réalisations : * - *Alfred & Compagnie <https://www.alfredetcompagnie.com/>* - *Comptoir des millesimes <https://www.comptoirdesmillesimes.com/>* - *Koziel <https://www.koziel.fr/fr/>* - *Tapis Chic <https://www.tapis-chic.com/>* *On parle de nous :* https://blog.dareboost.com/fr/2019/04/refonte-theme-prestashop-performance/ [image: SARL JUST WEB - Prestarocket] Adonis KARAVOKYROS Gérant PRESTAROCKET | LILLE m: 06.68.69.01.20 w: prestarocket.com e: [email protected] <[email protected]>

[dangelion]

@prestarocket is it still in development? For when you think it will be ready for production?

[dangelion]

@prestarocket can I use dev branch for a production project? Is it quiet stable?

[prestarocket]

yes