This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
Added config to support disabling of request started log lines and co… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrected a few typos: * corrected spelling of equipt to equipped * aligned verb tense of msg from “request started” and “request complete” to past tense for both: “request started” and “request completed” * corrected spelling of “resp_elasped_ms” to “resp_elapsed_ms”
VojtechVitek
reviewed
Jun 1, 2017
middleware.go
Outdated
| Logger *logrus.Logger | ||
| // WriteRequestStartedLine indicates if a request started line should be written or not. | ||
| // If false, only a request completed line will be written. | ||
| WriteRequestStartedLine bool |
There was a problem hiding this comment.
Let's just remove the "request started" line for good. We don't really need it. We don't need the toggle either.
If anyone needs to log this line for some reason, they can re-add it as their own middleware.
|
Closing. We're gonna update some attributes in v2.0. This is a breaking change. Can you please document what you want to change in a new issue? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rrected a few typos: